Support all garbage collector tests#2622
Open
zherczeg wants to merge 3 commits intoWebAssembly:mainfrom
Open
Conversation
zherczeg
force-pushed
the
gc_tests
branch
3 times, most recently
from
e973c0b to
2426298
Compare
Collaborator
Author
|
It looks like garbage collection tests are finally working. It took me 4 months, but the initial version of garbage collection support is completed. I think I understand the concept of references in WebAssembly, and know why it works that way. The code probably needs a lot of changes. |
zherczeg
force-pushed
the
gc_tests
branch
3 times, most recently
from
645b133 to
1917fb3
Compare
matetokodi
added a commit
to matetokodi/walrus
that referenced
this pull request
Jul 15, 2025
from: WebAssembly/wabt#2622 https://github.com/zherczeg/wabt/tree/gc_tests Signed-off-by: Máté Tokodi mate.tokodi@szteszoftver.hu
matetokodi
added a commit
to matetokodi/walrus
that referenced
this pull request
Jul 16, 2025
from: https://github.com/zherczeg/wabt/tree/gc_tests (1917fb3) WebAssembly/wabt#2622 Signed-off-by: Máté Tokodi mate.tokodi@szteszoftver.hu
matetokodi
added a commit
to matetokodi/walrus
that referenced
this pull request
Jul 18, 2025
from: https://github.com/zherczeg/wabt/tree/gc_tests (1917fb3) WebAssembly/wabt#2622 Signed-off-by: Máté Tokodi mate.tokodi@szteszoftver.hu
matetokodi
added a commit
to matetokodi/walrus
that referenced
this pull request
Jul 22, 2025
from: https://github.com/zherczeg/wabt/tree/gc_tests (1917fb3) WebAssembly/wabt#2622 Signed-off-by: Máté Tokodi mate.tokodi@szteszoftver.hu
matetokodi
added a commit
to matetokodi/walrus
that referenced
this pull request
Jul 22, 2025
from: https://github.com/zherczeg/wabt/tree/gc_tests (1917fb3) WebAssembly/wabt#2622 Signed-off-by: Máté Tokodi mate.tokodi@szteszoftver.hu
ksh8281
pushed a commit
to Samsung/walrus
that referenced
this pull request
Jul 31, 2025
from: https://github.com/zherczeg/wabt/tree/gc_tests (1917fb3) WebAssembly/wabt#2622 Signed-off-by: Máté Tokodi mate.tokodi@szteszoftver.hu
bfredl
added a commit
to bfredl/forklift
that referenced
this pull request
Nov 11, 2025
note: this requires a version of wabt which doesn't exist yet, see WebAssembly/wabt#2622
zherczeg
force-pushed
the
gc_tests
branch
2 times, most recently
from
46dac3d to
692da15
Compare
Contributor
|
So exciting to see this moving along! |
Collaborator
Author
|
Thank you! I try to update this patchset reguraly. The longer term aim is full wasm 3.0 support, but I also do some work on WebAssembly Components. Do you need this code for something? |
Contributor
|
I work with the |
Contributor
|
If you want a sample file: https://bouncing.web.app/main.dart.wasm |
zherczeg
force-pushed
the
gc_tests
branch
2 times, most recently
from
743218b to
595a459
Compare
zherczeg
force-pushed
the
gc_tests
branch
2 times, most recently
from
9e1178d to
afe6c80
Compare
This patch supports parsing the new GC types - Abstract types - Recursive types - Composite types The patch also improves type comparison.
Contributor
|
Sweet! |
Collaborator
Author
|
I am updating these patches but I don't know when they land. The first one in the set has a birthday soon! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This patch adds support for all tests in
testsuite/proposals/gc. Two tests are still missing.